feat: agent discovery#11
Merged
Merged
Conversation
SafeDep Report Summary
Package Details
This report is generated by SafeDep Github App |
abhisek
previously requested changes
May 11, 2026
setup was conflated with protect due to earlier naming churn (protect → endpoint, but endpoint was taken by cloud endpoint mgmt). Canonical MCP config commands now live at safedep protect mcp install/uninstall per the CLI Experience doc. setup mcp (the first-timer wizard shortcut = auth login + protect mcp install) is deferred to its own PR once the #787 onboarding path is ready.
Spec and plan files generated during the design session do not belong in project docs. Abhisek's review: remove these; internal skill convention uses docs/specs not docs/superpowers. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Claude Code stores user-level MCP servers in ~/.claude.json (where context7, notion etc. live), not ~/.claude/settings.json which is for permissions, model, and plugin settings. Entries in ~/.claude.json also require "type": "http" for remote servers. Workspace injection stays at .claude/settings.json within the project directory.
Antigravity defaults to SSE transport when no type is specified, causing "session not found" errors against Streamable HTTP servers. Adding "type": "streamable-http" explicitly directs Antigravity to use the correct transport.
VS Code uses "servers" (not "mcpServers") as the root key and "type": "http" + "url" for remote HTTP servers. Global user config lives in a platform-specific path (AppData on Windows/WSL2) that cannot be reliably resolved from the CLI, so only workspace injection is supported via .vscode/mcp.json. Detected via ~/.vscode-server (WSL2 Remote) or ~/.config/Code/User (native Linux). Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Previously, agents like VS Code (workspace-only) were detected and logged as "Configuring vscode" even without --workspace, but nothing was actually written. configurableAgents() now filters to agents that have at least one applicable injector given the current workspaceDir.
…ser/mcp.json VS Code Remote-WSL creates and reads ~/.config/Code/User/mcp.json on the Linux/WSL2 side. Global injection now writes there alongside the existing workspace injection at .vscode/mcp.json. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Linux/WSL2: ~/.config/Code/User/mcp.json macOS: ~/Library/Application Support/Code/User/mcp.json Windows: ~\AppData\Roaming\Code\User\mcp.json Detection uses the same OS-specific directory so VS Code is not falsely detected on systems where the relevant directory is absent. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
/sse is the legacy SSE endpoint. /mcp is the Streamable HTTP endpoint. Antigravity's "type": "streamable-http" was already correct.
An empty file (zero bytes) causes json.Unmarshal to return "unexpected end of JSON input". VS Code creates ~/.config/Code/User/mcp.json as an empty file before any MCP servers are configured. Treat len==0 the same as file-not-found in readJSONFile, removeMCPConfig, and removeVSCodeMCPConfig.
KunalSin9h
reviewed
May 15, 2026
KunalSin9h
reviewed
May 15, 2026
KunalSin9h
reviewed
May 15, 2026
KunalSin9h
reviewed
May 15, 2026
KunalSin9h
reviewed
May 15, 2026
KunalSin9h
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #788