fix: e2e readme test shouldn't use npm cache#79
Open
ryanrasti wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adjusts the README end-to-end usage test to avoid relying on npm’s offline cache behavior and to preserve temporary artifacts on failure for easier debugging.
Changes:
- Make
--prefer-offlineconditional based on install mode (only for working-tree installs). - Move temp directory deletion to only occur on successful test completion (so failures keep the temp dir).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| ? bashSnippet.replace(/\btypegres\b/, JSON.stringify(`file:${REPO_ROOT}`)) | ||
| : bashSnippet | ||
| ).replace(/\bnpm install\b/, "npm install --no-audit --no-fund --prefer-offline"); | ||
| ).replace(/\bnpm install\b/, `npm install --no-audit --no-fund ${mode === 'working-tree' ? '--prefer-offline' : ''}`); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.