fix: harden graph and postgres data integrity - #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
CREATE INDEX CONCURRENTLYHNSW builds before they can duplicate heap tuplesruvector.hnsw_ef_searchthe canonical GUC, retainruvector.ef_searchas an alias, and apply the configured width on every scanruvector-graphto 2.3.1 andruvector-postgresto 2.0.6Impact
This prevents duplicate HNSW results and silent SONA training loss, restores operator control over HNSW search cost/recall, and restores the graph distributed/all-features build.
Validation
cargo test -p ruvector-graph --all-features --lib— 199 passed, 3 ignoredcargo check -p ruvector-graph --all-featurescargo checkagainst PostgreSQL 16 withpg16,index-all,sona-learningcargo package -p ruvector-graph --allow-dirty --no-verifygit diff --checkCloses #727.
Closes #728.
Closes #729.
Closes #732.