feat(linfa-tsne): update to bhtsne 0.5.4 #429
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the bhtsne crate was fairly outdated, this new version is parallelized and allows using a custom distance metric (hence the added dependency on linfa-nn). That said, the version does not let you set the RNG used to initialize sampling (hence the removal of rng related apis).
AnthonyMichaelTDM
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #429 +/- ##
==========================================
- Coverage 77.00% 76.76% -0.24%
==========================================
Files 106 105 -1
Lines 7461 7359 -102
==========================================
- Hits 5745 5649 -96
+ Misses 1716 1710 -6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
should resolve that code coverage thing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the bhtsne crate was fairly outdated, the newest version is parallelized and allows using a custom distance metric (hence the added dependency on linfa-nn). That said, this version does not let you set the RNG used to initialize sampling (hence the removal of rng related apis).