Skip to content

Fix rustc-pull CI workflow#2070

Open
Kobzol wants to merge 1 commit intorust-lang:mainfrom
Kobzol:ci-pr-author
Open

Fix rustc-pull CI workflow#2070
Kobzol wants to merge 1 commit intorust-lang:mainfrom
Kobzol:ci-pr-author

Conversation

@Kobzol
Copy link
Copy Markdown
Member

@Kobzol Kobzol commented Apr 1, 2026

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 1, 2026

r? @sayantn

rustbot has assigned @sayantn.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Amanieu, @folkertdev, @sayantn
  • @Amanieu, @folkertdev, @sayantn expanded to Amanieu, folkertdev, sayantn
  • Random selection from Amanieu, folkertdev, sayantn

@Kobzol Kobzol requested a review from folkertdev April 1, 2026 09:08
@Kobzol
Copy link
Copy Markdown
Member Author

Kobzol commented Apr 1, 2026

The CI failure looks unrelated, probably will need some other fix.

@sayantn
Copy link
Copy Markdown
Contributor

sayantn commented Apr 1, 2026

the tests are failing because the fix in rust-lang/rust#154043 didn't yet propagate to this repo - it requires a sync job

@folkertdev
Copy link
Copy Markdown
Contributor

Yes but the sync job is blocked on this PR :)

And also on a hexagon libc issue, that needs to be resolved in the main repo first. So, we're blocked for now.

@sayantn
Copy link
Copy Markdown
Contributor

sayantn commented Apr 1, 2026

Yes but the sync job is blocked on this PR :)

And also on a hexagon libc issue, that needs to be resolved in the main repo first. So, we're blocked for now.

😕 so does this mean we would need infra admins to step in and perform a manual sync?

@folkertdev
Copy link
Copy Markdown
Contributor

I've just cherry-picked the commit here onto the sync, that should work if not for the hexagon build issue. So we'll just have to wait a bit.

@tgross35
Copy link
Copy Markdown
Contributor

tgross35 commented Apr 4, 2026

I mentioned in the libc discussion but you should probably drop the Hexagon job for now if it's blocking things. T3 targets are absolutely not consistently tested across rust-lang (nor should they be) so if you've accepted a CI job testing any of them in this repo, you need to be ready to do that. Or at the very least, mark it continue-on-error.

Looks like the nvptx job is the one failing though?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants