Skip to content

Only honor -Zincremental-verify-ich for incremental compiles #159796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xmakro wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Only honor -Zincremental-verify-ich for incremental compiles #159796

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion compiler/rustc_query_impl/src/plumbing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,12 @@ fn encode_query_values_inner<'a, 'tcx, C, V>(
}

pub(crate) fn verify_query_key_hashes<'tcx>(tcx: TyCtxt<'tcx>) {
if tcx.sess.opts.unstable_opts.incremental_verify_ich || cfg!(debug_assertions) {
// Check for query key fingerprint collisions (which break incremental
// compilation) in debug builds, or under `-Zincremental-verify-ich`.
// The flag is ignored in non-incremental builds, where rustc-perf still passes it.
if cfg!(debug_assertions)
|| (tcx.sess.opts.unstable_opts.incremental_verify_ich && tcx.dep_graph.is_fully_enabled())
{
tcx.sess.time("verify_query_key_hashes", || {
for_each_query_vtable!(ALL, tcx, |query| {
verify_query_key_hashes_inner(query, tcx);
Expand Down
Loading