fix(rustc_hir_analysis): handle Node::Synthetic in diagnostic_hir_wf_check

[DAstapov]

Closes #159557
Closes #148630

[rustbot]

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @jieyouxu (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 74 candidates
• Random selection from 17 candidates

[rustbot]

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

[jieyouxu]

Question: why?

View changes since the review

[DAstapov]

The test is only needed to verify that no ICE is issued during compilation, and since the test produces many identical errors, I decided not to add explicit //~^ ERROR annotations, because the output is already checked via the .stderr file.
I'm not sure what the correct approach is here.

[jieyouxu]

This should just use normal error annotations and not ignore them. The test harness already will assert the compiler normally errors and doesn't ICE.

[DAstapov]

Fixed