Clarify the comment about stage1/stage2 discrepancy in input-stats test#159616
Merged
rust-bors[bot] merged 1 commit intoJul 21, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
nnethercote
approved these changes
Jul 20, 2026
Contributor
|
Good clarification. @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Jul 21, 2026
Rollup of 14 pull requests Successful merges: - #159307 (Improve cross-namespace name diagnostics) - #159543 (Remove extra semicolons in parsing item lists) - #157270 (ergonomic_clones_dotuse_capture_by_ref: Capture upvar by ref for `.use` in non-move closures) - #158496 (Move `check_rustc_pub_transparent` into the attribute parser) - #158547 (Move `std::io::buffered` to `alloc::io`) - #158808 (Filter host libstdc++ ABI flag in rustc_llvm cross builds) - #159362 (Add regression test for #120328) - #159472 (Support creating float constants in rustc_public mir) - #159505 (make rustdoc::bare_urls strip trailing periods from url) - #159568 (Suggest close compiler options) - #159578 (Extract coroutine closure helper functions) - #159601 (Make `TokenTreeCursor` private) - #159613 (Set the rustc lib path for unstable-book-gen) - #159616 (Clarify the comment about stage1/stage2 discrepancy in input-stats test)
rust-timer
added a commit
that referenced
this pull request
Jul 21, 2026
Rollup merge of #159616 - panstromek:clarify-input-stats-layout-change-comment, r=nnethercote Clarify the comment about stage1/stage2 discrepancy in input-stats test I was very confused by this comment. The test in question breaks when you change AST types and the comment says "Type layout sometimes change" which seems to imply that you have to do the `ignore-stage1` flip to fix it. But we do these layout changes all the time and I haven't seen anybody to do this. It only became clear only when I dug through history and found the last time the `ignore-stage1` was used here (on layout algorithm change in 2023). It's only relevant when type layouts change in _rustc output_, not in rustc source code. r? nnethercote
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was very confused by this comment. The test in question breaks when you change AST types and the comment says "Type layout sometimes change" which seems to imply that you have to do the
ignore-stage1flip to fix it. But we do these layout changes all the time and I haven't seen anybody to do this.It only became clear only when I dug through history and found the last time the
ignore-stage1was used here (on layout algorithm change in 2023). It's only relevant when type layouts change in rustc output, not in rustc source code.r? nnethercote