[crater experiment] lint against Struct { .. } when Struct has all private fields

[Jules-Bertholet]

View all comments

Draft as this is just a Crater experiment, and should not be merged.

Deny-by-default lint on Struct { .. } patterns where Struct has only fields not visible from the location of the pattern (if it has no fields, it must be from a foreign crate and #[non_exhaustive]). This is to gather data to inform rust-lang/rfcs#3753.

@rustbot label A-patterns T-lang
@rustbot ready

r? compiler

[mati865]

Please describe what kind of crater run do you need: https://rustc-dev-guide.rust-lang.org/tests/crater.html#requesting-crater-runs
Looks like a check-only to me.

@bors try

[Jules-Bertholet]

Yes, check-only

[rust-bors]

💔 Test for 86531a3 failed: CI. Failed job:

• try - dist-x86_64-linux-quick (web logs, enhanced plaintext logs)

[mati865]

@Jules-Bertholet the toolchain must be buildable to run crater.

[Jules-Bertholet]

@rustbot ready
@rustbot label -A-attributes

[theemathas]

@bors try

[rust-log-analyzer]

The job aarch64-gnu-llvm-21-2 failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

  |
  = note: using it is strongly discouraged
  = note: `#[warn(internal_features)]` on by default

error: crater fail !! problematic pattern detected !!
    --> compiler/rustc_lint/src/builtin.rs:3214:9
     |
3214 |         Foo { .. } => (),
     |         ^^^^^^^^^^
     |

[theemathas]

@Jules-Bertholet

[Jules-Bertholet]

Test failures don't matter for crater, it just needs to build

[theemathas]

Oh, sorry. My bad.

@craterbot check

[craterbot]

🚨 Error: missing start toolchain

🆘 If you have any trouble with Crater please ask in t-infra on Zulip
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[theemathas]

Oh whoops. I need to wait for the try build to finish first. Duh.

[rust-bors]

☀️ Try build successful (CI)
Build commit: 6e4b95e (6e4b95ed0735c3bbfb308e6f158f479b4d14f1aa)
Base parent: eff8269 (eff8269f797067c30555e77f160ec84c0ed15cd9)

[theemathas]

@craterbot check

[craterbot]

👌 Experiment pr-159356 created and queued.
🤖 Automatically detected try build 6e4b95e
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[rust-bors]

☔ The latest upstream changes (presumably #160238) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

[craterbot]

🚧 Experiment pr-159356 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-159356 is completed!
📊 174 regressed and 9 fixed (1035365 total)
📊 6818 spurious results on the retry-regressed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-159356/retry-regressed-list.txt ↩

[mati865]

@rustbot author

[rustbot]

Reminder, once the PR becomes ready for a review, use @rustbot ready.