Skip to content

Correctly handle Deref specialization in rustdoc#157272

Open
GuillaumeGomez wants to merge 1 commit into
rust-lang:mainfrom
GuillaumeGomez:deref-specialization
Open

Correctly handle Deref specialization in rustdoc#157272
GuillaumeGomez wants to merge 1 commit into
rust-lang:mainfrom
GuillaumeGomez:deref-specialization

Conversation

@GuillaumeGomez

@GuillaumeGomez GuillaumeGomez commented Jun 1, 2026

Copy link
Copy Markdown
Member

Fixes #156484.

Not sure if this is the right way to handle specialization though as it doesn't provide more information as you can see:

image

But at least it doesn't panic anymore.

r? @Urgau

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 1, 2026
@Urgau

Urgau commented Jun 2, 2026

Copy link
Copy Markdown
Member

I also have no idea how we should handle Deref specialization, I didn't even know it was a thing.

Do we even want to show an impl in this case? How do we handle specialization in other cases?

@Urgau Urgau added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2026
@rust-bors

rust-bors Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

☔ The latest upstream changes (presumably #159623) made this pull request unmergeable. Please resolve the merge conflicts by rebasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ICE]: rustdoc: Deref impl without Target type

3 participants