Rollup of 10 pull requests by jhpratt · Pull Request #155077 · rust-lang/rust

jhpratt · 2026-04-10T04:00:04Z

Successful merges:

Break a single query cycle in the deadlock handler #154973 (Break a single query cycle in the deadlock handler)
Implement GenericTypeVisitable for some types #155034 (Implement GenericTypeVisitable for some types)
Fix linker error by resolving regions for main return type obligations #151377 (Fix linker error by resolving regions for main return type obligations)
hwaddress: automatically add -Ctarget-feature=+tagged-globals #154677 (hwaddress: automatically add -Ctarget-feature=+tagged-globals)
Add myself as co-maintainer for hexagon-unknown-linux-musl #154774 (Add myself as co-maintainer for hexagon-unknown-linux-musl)
Add tests for three fixed issues (an LLVM crash, an ICE and poor codegen) #155015 (Add tests for three fixed issues (an LLVM crash, an ICE and poor codegen))
minor follow up to removing soft mode #[unstable] #155039 (minor follow up to removing soft mode #[unstable])
Fix if branch in op.rs #155043 (Fix if branch in op.rs)
Deny #[global_allocator] + #[thread_local] #155071 (Deny #[global_allocator] + #[thread_local])
Set the Fuchsia ABI to the documented minimum #155072 (Set the Fuchsia ABI to the documented minimum)

@androm3da

Two dedicated target maintainers are needed for tier 2 promotion. Coordinated with the existing maintainer @androm3da.

This is required for rust-analyzer.

Fuchsia only supports the RVA22 + vector as its minimum ABI for RISC-V. https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0234_riscv_abi_rva22+vector

Break a single query cycle in the deadlock handler This simplifies the query cycle handling by only breaking a single query cycle each time the deadlock handler is called.

Implement `GenericTypeVisitable` for some types This is required for rust-analyzer. r? types

Fix linker error by resolving regions for main return type obligations This PR fix linker error by resolving regions for main return type obligations as discussed in rust-lang#148421 Added a final check . Now the compiler double-checks the lifetimes for main right away. If they don't work it stops and gives the user a clean compiler error instead of a linker crash. Fixes rust-lang#148421.

…davidtwco hwaddress: automatically add `-Ctarget-feature=+tagged-globals` Note that since HWAddressSanitizer is/should be a target modifier, we do not have to worry about whether this LLVM target feature changes the ABI. Fixes: rust-lang#148185

@androm3da

…O8Ki Add myself as co-maintainer for hexagon-unknown-linux-musl Two dedicated target maintainers are needed for tier 2 promotion. Coordinated with the existing maintainer r? @androm3da.

…3899, r=Kivooeo Add tests for three fixed issues (an LLVM crash, an ICE and poor codegen) Closes rust-lang#104037. Closes rust-lang#112623. Closes rust-lang#113899.

…thanBrouwer minor follow up to removing soft mode `#[unstable]` Follow up to rust-lang#153622 r? JonathanBrouwer

@hkBst

…adwinwhite Fix if branch in op.rs I removed the if guard without thinking in rust-lang#154223. Really sorry about this. r? @hkBst

…=Kivooeo Deny `#[global_allocator]` + `#[thread_local]` This forbids using `#[thread_local]` on `static` items that are also `#[global_allocator]`s. Fixes rust-lang#85517.

…lt, r=jieyouxu Set the Fuchsia ABI to the documented minimum Fuchsia only supports the RVA22 + vector as its minimum ABI for RISC-V. See: [fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0234_riscv_abi_rva22+v](https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0234_riscv_abi_rva22+v)[fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0234_riscv_abi_rva22+v](https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0234_riscv_abi_rva22+v)

jhpratt · 2026-04-10T04:00:24Z

@bors r+ rollup=never p=5

rust-bors · 2026-04-10T04:00:28Z

📌 Commit 4f606c8 has been approved by jhpratt

It is now in the queue for this repository.

rust-bors · 2026-04-10T09:57:56Z

☀️ Test successful - CI
Approved by: jhpratt
Duration: 3h 31m 25s
Pushing 25a54d4 to main...

rust-timer · 2026-04-10T10:00:52Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#151377	Fix linker error by resolving regions for main return type …	`8c5bd21611e5ec4cb84d4580ab6fa7a4855e00bd` (link)
#154677	hwaddress: automatically add `-Ctarget-feature=+tagged-glob…	`9d945a7100365abd908e0238754b0a00472bdba8` (link)
#154774	Add myself as co-maintainer for hexagon-unknown-linux-musl	`c91ccdd26ebebc27f25baee10bb9eadb011cbe5a` (link)
#154973	Break a single query cycle in the deadlock handler	`c5aa313a5787e8f3f62fd7f0e84cfd4f2226c43e` (link)
#155015	Add tests for three fixed issues (an LLVM crash, an ICE and…	`5ed070b22b6e2dfdad1d36f55483567444413226` (link)
#155034	Implement `GenericTypeVisitable` for some types	`34e0ed3a7b32f1fb73e8deca591152c20fe725e5` (link)
#155039	minor follow up to removing soft mode `#[unstable]`	`43eb68cc12290022317e3b04e1cfd3770a233365` (link)
#155043	Fix if branch in op.rs	`49098f6c933bcb5c55c0b8832a75d215e93c6526` (link)
#155071	Deny `#[global_allocator]` + `#[thread_local]`	`e5561466cea17dadfdcfc3fcf9184894f25642bc` (link)
#155072	Set the Fuchsia ABI to the documented minimum	`2a529cd23888b991bf3ec0936f4ad925e6df9445` (link)

previous master: 7659cec4ed

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2026-04-10T10:01:18Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 7659cec (parent) -> 25a54d4 (this PR)

Test differences

Show 14 test diffs

Stage 1

[ui] tests/ui/allocator/no-thread-local.rs: [missing] -> pass (J0)
[ui] tests/ui/derives/clone-vector-element-size.rs: [missing] -> pass (J0)
[ui] tests/ui/traits/const-traits/self-receiver-type-mismatch.rs: [missing] -> pass (J0)
[ui] tests/ui/typeck/main-termination-lifetime-issue-148421.rs: [missing] -> pass (J0)
[codegen] tests/codegen-llvm/enum/enum-array-index-spare-niche.rs: [missing] -> pass (J1)

Stage 2

[ui] tests/ui/allocator/no-thread-local.rs: [missing] -> pass (J2)
[ui] tests/ui/derives/clone-vector-element-size.rs: [missing] -> pass (J2)
[ui] tests/ui/traits/const-traits/self-receiver-type-mismatch.rs: [missing] -> pass (J2)
[ui] tests/ui/typeck/main-termination-lifetime-issue-148421.rs: [missing] -> pass (J2)
[codegen] tests/codegen-llvm/enum/enum-array-index-spare-niche.rs: [missing] -> pass (J3)

Additionally, 4 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 25a54d4ba87873ef02ef0e5fce49baa57198deb3 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-msvc-ext2: 1h 25m -> 1h 55m (+34.2%)
dist-aarch64-apple: 1h 36m -> 1h 57m (+22.0%)
dist-aarch64-llvm-mingw: 1h 50m -> 1h 35m (-13.6%)
x86_64-gnu-nopt: 2h 13m -> 2h 28m (+11.2%)
aarch64-apple: 3h 5m -> 3h 23m (+10.0%)
aarch64-gnu-debug: 1h 20m -> 1h 12m (-9.6%)
dist-apple-various: 1h 45m -> 1h 36m (-9.0%)
x86_64-mingw-2: 2h 27m -> 2h 38m (+7.2%)
x86_64-gnu-stable: 2h 17m -> 2h 26m (+6.8%)
x86_64-gnu-llvm-22-1: 1h 14m -> 1h 9m (-6.3%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2026-04-10T10:38:17Z

Finished benchmarking commit (25a54d4): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (secondary 0.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	6.9%	[6.9%, 6.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-6.2%	[-6.2%, -6.2%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary -3.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.1%	[-3.6%, -2.6%]	2
All ❌✅ (primary)	-	-	0

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 492.281s -> 488.4s (-0.79%)
Artifact size: 395.57 MiB -> 395.55 MiB (-0.01%)

Darksonn and others added 26 commits April 1, 2026 12:38

hwaddress: automatically add -Ctarget-feature=tagged-globals

6fc3880

Add myself as co-maintainer for hexagon-unknown-linux-musl

221c39a

Two dedicated target maintainers are needed for tier 2 promotion. Coordinated with the existing maintainer @androm3da.

Break a single query cycle in the deadlock handler

690d193

Add a test for an LLVM crash "Vector elements must have same size"

f493cab

Add a test for a const evaluator ICE on a self-receiver type mismatch

12e847f

Add a codegen test for a missed optimisation with spare niches

fc9f492

minor follow up to removing soft mode #[unstable]

0fbab04

Implement GenericTypeVisitable for some types

6cd5315

This is required for rust-analyzer.

Fix if branch in op.rs

d024e57

main-termination

dbc08cf

Add (failing) ui test for denying global_allocator + thread_local

b65574d

Deny global_allocator + thread_local

95c1a37

Update ui test for deny global_allocator + thread_local

9614f28

Improve diagnostic for global_allocator + thread_local

dbe7a4e

Apply suggestions from fmt output

b537c45

Set the Fuchsia ABI to the documented minimum

a2255aa

Fuchsia only supports the RVA22 + vector as its minimum ABI for RISC-V. https://fuchsia.dev/fuchsia-src/contribute/governance/rfcs/0234_riscv_abi_rva22+vector

Rollup merge of rust-lang#154973 - Zoxc:cycle-single, r=petrochenkov

e249b03

Break a single query cycle in the deadlock handler This simplifies the query cycle handling by only breaking a single query cycle each time the deadlock handler is called.

Rollup merge of rust-lang#155034 - ChayimFriedman2:ra-fixes, r=lcnr

6e7e947

Implement `GenericTypeVisitable` for some types This is required for rust-analyzer. r? types

Rollup merge of rust-lang#154774 - quic-mliebel:add-maintainer, r=TaK…

8220818

…O8Ki Add myself as co-maintainer for hexagon-unknown-linux-musl Two dedicated target maintainers are needed for tier 2 promotion. Coordinated with the existing maintainer r? @androm3da.

Rollup merge of rust-lang#155015 - jakubadamw:issues-104037-112623-11…

d788fbf

…3899, r=Kivooeo Add tests for three fixed issues (an LLVM crash, an ICE and poor codegen) Closes rust-lang#104037. Closes rust-lang#112623. Closes rust-lang#113899.

Rollup merge of rust-lang#155039 - WaffleLapkin:hard_unstable, r=Jona…

ddf6fae

…thanBrouwer minor follow up to removing soft mode `#[unstable]` Follow up to rust-lang#153622 r? JonathanBrouwer

Rollup merge of rust-lang#155043 - malezjaa:refactor-typecheck-op, r=…

5d8f9c8

…adwinwhite Fix if branch in op.rs I removed the if guard without thinking in rust-lang#154223. Really sorry about this. r? @hkBst

Rollup merge of rust-lang#155071 - Fayti1703:alloc/no-thread-local, r…

c305a1a

…=Kivooeo Deny `#[global_allocator]` + `#[thread_local]` This forbids using `#[thread_local]` on `static` items that are also `#[global_allocator]`s. Fixes rust-lang#85517.

rust-bors bot added the rollup A PR which is a rollup label Apr 10, 2026

rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) PG-exploit-mitigations Project group: Exploit mitigations labels Apr 10, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 10, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2026

This comment has been minimized.

Sign in to view

rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 10, 2026

rust-bors bot merged commit 25a54d4 into rust-lang:main Apr 10, 2026
12 checks passed

rustbot added this to the 1.96.0 milestone Apr 10, 2026

jhpratt deleted the rollup-6HqPjEt branch April 10, 2026 10:01

This was referenced Apr 10, 2026

Introduce Unnormalized wrapper #155083

Open

Add new misleading_cfg_in_build_script lint #153721

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 10 pull requests#155077

Rollup of 10 pull requests#155077
rust-bors[bot] merged 26 commits intorust-lang:mainfrom
jhpratt:rollup-6HqPjEt

jhpratt commented Apr 10, 2026

Uh oh!

jhpratt commented Apr 10, 2026

Uh oh!

rust-bors bot commented Apr 10, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Apr 10, 2026

Uh oh!

Uh oh!

rust-timer commented Apr 10, 2026

Uh oh!

github-actions bot commented Apr 10, 2026

Stage 1

Stage 2

Uh oh!

rust-timer commented Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Uh oh!

Conversation

jhpratt commented Apr 10, 2026

Uh oh!

jhpratt commented Apr 10, 2026

Uh oh!

rust-bors bot commented Apr 10, 2026

Uh oh!

This comment has been minimized.

rust-bors bot commented Apr 10, 2026

Uh oh!

Uh oh!

rust-timer commented Apr 10, 2026

Uh oh!

github-actions bot commented Apr 10, 2026

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Apr 10, 2026

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants