delegation: fix unelided lifetime ICE, refactoring of GenericArgPosition by aerooneqq · Pull Request #155031 · rust-lang/rust

aerooneqq · 2026-04-09T09:25:49Z

View all comments

This PR does two things:

First it restores lower_generic_args_of_path as it was before Implement AST -> HIR generics propagation in delegation #151864, as it turns out we should use GenericArgPosition::Type for generic args lowering for signature inheritance, as it will not cause lifetime inference and then ICEs during child args lowering,
Next it refactors GenericArgPosition enum replacing Value and MethodCall with Call(IsMethodCall), as the only place where we created Value or MethodCall variants was in check_generic_arg_count_for_call, where it was a match over is_method_call. Not sure it is needed, but seems cleaner to me.

Fixes #154178, part of #118212.

r? @petrochenkov

rustbot · 2026-04-09T09:25:55Z

HIR ty lowering was modified

cc @fmease

petrochenkov · 2026-04-09T12:00:17Z

@bors r+

rust-bors · 2026-04-09T12:00:21Z

📌 Commit 5eea9f8 has been approved by petrochenkov

It is now in the queue for this repository.

fmease

I'm sorry, one minor nit. @bors r-

View changes since this review

compiler/rustc_hir_analysis/src/hir_ty_lowering/generics.rs

compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs

rustbot · 2026-04-09T12:15:21Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

tests/ui/delegation/generics/unelided-lifetime-ice-154178.rs

aerooneqq · 2026-04-09T12:49:10Z

@rustbot ready

fmease · 2026-04-09T13:41:02Z

Thanks!

@bors r=petrochenkov,fmease rollup

rust-bors · 2026-04-09T13:41:06Z

📌 Commit 5a32e40 has been approved by petrochenkov,fmease

It is now in the queue for this repository.

@petrochenkov

…lowering-ice, r=petrochenkov,fmease delegation: fix unelided lifetime ICE, refactoring of GenericArgPosition This PR does two things: - First it restores `lower_generic_args_of_path` as it was before rust-lang#151864, as it turns out we should use `GenericArgPosition::Type` for generic args lowering for signature inheritance, as it will not cause lifetime inference and then ICEs during child args lowering, - Next it refactors `GenericArgPosition` enum replacing `Value` and `MethodCall` with `Call(IsMethodCall)`, as the only place where we created `Value` or `MethodCall` variants was in `check_generic_arg_count_for_call`, where it was a match over `is_method_call`. Not sure it is needed, but seems cleaner to me. Fixes rust-lang#154178, part of rust-lang#118212. r? @petrochenkov

JonathanBrouwer · 2026-04-09T19:51:51Z

@bors r-
#155061 (comment)

rust-bors · 2026-04-09T19:51:58Z

This pull request was unapproved.

This PR was contained in a rollup (#155061), which was unapproved.

rustbot · 2026-04-10T06:54:09Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

aerooneqq · 2026-04-10T07:04:37Z

@rustbot ready

JonathanBrouwer · 2026-04-10T09:18:35Z

@bors try jobs=x86_64-gnu-llvm-21-3

…e, r=<try> delegation: fix unelided lifetime ICE, refactoring of GenericArgPosition try-job: x86_64-gnu-llvm-21-3

petrochenkov · 2026-04-10T11:10:27Z

r=me after CI is green.

petrochenkov · 2026-04-10T11:10:48Z

@rustbot author
@bors delegate+

rust-bors · 2026-04-10T11:10:52Z

✌️ @aerooneqq, you can now approve this pull request!

If @petrochenkov told you to "r=me" after making some further change, then please make that change and post @bors r=petrochenkov.

rust-bors · 2026-04-10T11:11:51Z

☀️ Try build successful (CI)
Build commit: 1e777aa (1e777aa357e03a51137afb68b540e903c1456c89, parent: 7659cec4ed1457bc0d1f636127e66e8fe5008928)

aerooneqq · 2026-04-10T11:18:34Z

@bors r+

rust-bors · 2026-04-10T11:18:38Z

📌 Commit 9e8069f has been approved by aerooneqq

It is now in the queue for this repository.

fmease · 2026-04-10T11:22:03Z

@bors r=petrochenkov

rust-bors · 2026-04-10T11:22:06Z

📌 Commit 9e8069f has been approved by petrochenkov

It is now in the queue for this repository.

@petrochenkov

…lowering-ice, r=petrochenkov delegation: fix unelided lifetime ICE, refactoring of GenericArgPosition This PR does two things: - First it restores `lower_generic_args_of_path` as it was before rust-lang#151864, as it turns out we should use `GenericArgPosition::Type` for generic args lowering for signature inheritance, as it will not cause lifetime inference and then ICEs during child args lowering, - Next it refactors `GenericArgPosition` enum replacing `Value` and `MethodCall` with `Call(IsMethodCall)`, as the only place where we created `Value` or `MethodCall` variants was in `check_generic_arg_count_for_call`, where it was a match over `is_method_call`. Not sure it is needed, but seems cleaner to me. Fixes rust-lang#154178, part of rust-lang#118212. r? @petrochenkov

…uwer Rollup of 8 pull requests Successful merges: - #155047 (Always exhaustively match on typing mode) - #155080 (Simplify `try_load_from_disk_fn`.) - #152384 (Restrict EII declarations to functions at lowering time) - #153796 (Fix ICE when combining #[eii] with #[core::contracts::ensures]) - #154369 (Fix `pattern_from_macro_note` for bit-or expr) - #155027 ( Rename some more of our internal `#[rustc_*]` TEST attributes) - #155031 (delegation: fix unelided lifetime ICE, refactoring of GenericArgPosition) - #155040 (Fix code block whitespace handling in Markdown)

@petrochenkov

Rollup merge of #155031 - aerooneqq:delegation-generic-args-lowering-ice, r=petrochenkov delegation: fix unelided lifetime ICE, refactoring of GenericArgPosition This PR does two things: - First it restores `lower_generic_args_of_path` as it was before #151864, as it turns out we should use `GenericArgPosition::Type` for generic args lowering for signature inheritance, as it will not cause lifetime inference and then ICEs during child args lowering, - Next it refactors `GenericArgPosition` enum replacing `Value` and `MethodCall` with `Call(IsMethodCall)`, as the only place where we created `Value` or `MethodCall` variants was in `check_generic_arg_count_for_call`, where it was a match over `is_method_call`. Not sure it is needed, but seems cleaner to me. Fixes #154178, part of #118212. r? @petrochenkov

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 9, 2026

rustbot assigned petrochenkov Apr 9, 2026

This comment has been minimized.

Sign in to view

aerooneqq force-pushed the delegation-generic-args-lowering-ice branch from 1d62869 to 5eea9f8 Compare April 9, 2026 10:07

petrochenkov added the F-fn_delegation `#![feature(fn_delegation)]` label Apr 9, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2026

fmease requested changes Apr 9, 2026

View reviewed changes

compiler/rustc_hir_analysis/src/hir_ty_lowering/generics.rs Outdated Show resolved Hide resolved

compiler/rustc_hir_analysis/src/hir_ty_lowering/mod.rs Outdated Show resolved Hide resolved

rustbot added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 9, 2026

rust-bors bot removed the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Apr 9, 2026

petrochenkov reviewed Apr 9, 2026

View reviewed changes

tests/ui/delegation/generics/unelided-lifetime-ice-154178.rs Outdated Show resolved Hide resolved

aerooneqq force-pushed the delegation-generic-args-lowering-ice branch from 5eea9f8 to 5a32e40 Compare April 9, 2026 12:47

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 9, 2026

aerooneqq changed the title ~~delegation: fix unelided lifetime ICE, small refactoring of GenericArgPosition~~ delegation: fix unelided lifetime ICE, refactoring of GenericArgPosition Apr 9, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2026

JonathanBrouwer mentioned this pull request Apr 9, 2026

Rollup of 11 pull requests #155061

Closed

rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 9, 2026

Fix unelided lifetime ICE, refactoring of GenericArgPosition

9e8069f

aerooneqq force-pushed the delegation-generic-args-lowering-ice branch from 5a32e40 to 9e8069f Compare April 10, 2026 06:54

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 10, 2026

This comment has been minimized.

Sign in to view

rust-bors bot pushed a commit that referenced this pull request Apr 10, 2026

Auto merge of #155031 - aerooneqq:delegation-generic-args-lowering-ic…

1e777aa

…e, r=<try> delegation: fix unelided lifetime ICE, refactoring of GenericArgPosition try-job: x86_64-gnu-llvm-21-3

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 10, 2026

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 10, 2026

This was referenced Apr 10, 2026

Rollup of 5 pull requests #155094

Closed

Rollup of 8 pull requests #155099

Merged

rust-bors bot merged commit 3b8c7ec into rust-lang:main Apr 10, 2026
12 checks passed

rustbot added this to the 1.96.0 milestone Apr 10, 2026

Uh oh!

Conversation

aerooneqq commented Apr 9, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Apr 9, 2026

Uh oh!

This comment has been minimized.

petrochenkov commented Apr 9, 2026

Uh oh!

rust-bors bot commented Apr 9, 2026

Uh oh!

fmease left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

rustbot commented Apr 9, 2026

Uh oh!

Uh oh!

aerooneqq commented Apr 9, 2026

Uh oh!

fmease commented Apr 9, 2026

Uh oh!

rust-bors bot commented Apr 9, 2026

Uh oh!

JonathanBrouwer commented Apr 9, 2026

Uh oh!

rust-bors bot commented Apr 9, 2026

Uh oh!

rustbot commented Apr 10, 2026

Uh oh!

aerooneqq commented Apr 10, 2026

Uh oh!

JonathanBrouwer commented Apr 10, 2026

Uh oh!

This comment has been minimized.

petrochenkov commented Apr 10, 2026

Uh oh!

petrochenkov commented Apr 10, 2026

Uh oh!

rust-bors bot commented Apr 10, 2026

Uh oh!

rust-bors bot commented Apr 10, 2026

Uh oh!

aerooneqq commented Apr 10, 2026

Uh oh!

rust-bors bot commented Apr 10, 2026

Uh oh!

fmease commented Apr 10, 2026

Uh oh!

rust-bors bot commented Apr 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

aerooneqq commented Apr 9, 2026 •

edited by rustbot

Loading

fmease left a comment •

edited by rustbot

Loading