feat: reimplement hash_map! macro#154322
Open
m4rch3n1ng wants to merge 1 commit intorust-lang:mainfrom
Open
Conversation
Co-authored-by: stifskere <esteve@memw.es>
rustbot
added
S-waiting-on-review
Collaborator
|
rustbot has assigned @Mark-Simulacrum. Use Why was this reviewer chosen?The reviewer was selected based on:
|
smmalis37
reviewed
Mar 25, 2026
| }}; | ||
|
|
||
| ( $( $key:expr => $value:expr ),* $(,)? ) => {{ | ||
| let mut map = $crate::collections::HashMap::with_capacity( |
Contributor
There was a problem hiding this comment.
I'm curious as to why this is implemented this way instead of using the From<[T;N]> impl. Wouldn't that be simpler, as it would remove the need for the repetition count machinery?
Contributor
Author
There was a problem hiding this comment.
see this comment on the thread of the original implementation
Contributor
There was a problem hiding this comment.
Hah, yeah that's a good reason
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
originally implemented in #144070, this had to be reverted in #148049 due to name ambiguity, as the macro was automatically put into the prelude. now, that #139493 has landed, it is possible to have a top-level macro, that is not exported by default, which should make it possible to reland this again.
implements #144032
implementation from #144070, original author has been added as co-author
effectively reverts #148049