Skip to content

Revert "Move aarch64-apple dist builder to dynamic llvm linking"#153079

Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
RalfJung:revert-macos-dyn
Feb 26, 2026
Merged

Revert "Move aarch64-apple dist builder to dynamic llvm linking"#153079
rust-bors[bot] merged 1 commit intorust-lang:mainfrom
RalfJung:revert-macos-dyn

Conversation

@RalfJung
Copy link
Copy Markdown
Member

@RalfJung RalfJung commented Feb 25, 2026

View all comments

Reverts c033de9 (part of #152768) in order to fix #153077.

@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc labels Feb 25, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Feb 25, 2026

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: bootstrap
  • bootstrap expanded to 6 candidates
  • Random selection from Mark-Simulacrum, clubby789, jieyouxu

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Feb 25, 2026
@rustbot

This comment has been minimized.

@RalfJung
Copy link
Copy Markdown
Member Author

@bors try=dist-aarch64-apple

I hope this will let me then try this commit in Miri's CI (i.e., install it via rustup-toolchain-install-master).

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Feb 25, 2026

Unknown command "try". Run @bors help to see available commands.

@RalfJung
Copy link
Copy Markdown
Member Author

@bors try jobs=dist-aarch64-apple

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Feb 25, 2026
Revert "Enable autodiff in ci for all major os"


try-job: dist-aarch64-apple
Copy link
Copy Markdown
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me if this unbricks miri's CI

EDIT: ok nvm I saw #152768 (comment), I agree with revert-to-baseline.

View changes since this review

@jieyouxu jieyouxu self-assigned this Feb 25, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Feb 25, 2026

☀️ Try build successful (CI)
Build commit: 9de1b89 (9de1b8948048dab882aae4ba9b9d1039d654cbeb, parent: 11ad63a942c380b83a1fbfe5f0ecb1caaad4c7c1)

@RalfJung
Copy link
Copy Markdown
Member Author

Indeed this does fix the Miri problem.

@bors r=jieyouxu p=1

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Feb 25, 2026

📌 Commit 650501e has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2026
@Kobzol
Copy link
Copy Markdown
Member

Kobzol commented Feb 25, 2026

CC @ZuseZ4

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 25, 2026
Revert "Enable autodiff in ci for all major os"

Reverts rust-lang#152768 which fixes  rust-lang#153077.
@ZuseZ4
Copy link
Copy Markdown
Member

ZuseZ4 commented Feb 25, 2026

If that's not in the queue yet, can you please only revert the macos commit? I extra had that one split out.

@RalfJung
Copy link
Copy Markdown
Member Author

RalfJung commented Feb 25, 2026

#153084 already started the build so we'd have to abort the rollup. It wasn't clear whether CI was expected to pass with just that one commit reverted and I didn't want to risk this PR bouncing.

@RalfJung
Copy link
Copy Markdown
Member Author

Oh wait that's just a try build there. Okay then I can update the PR. I hope you're sure that that'll land. :)

@bors r-

@rust-bors rust-bors bot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 25, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Feb 25, 2026

Commit 650501e has been unapproved.

This PR was contained in a rollup (#153084), which was also unapproved.

@rust-bors rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 26, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Feb 26, 2026

💔 Test for e5763e7 failed: CI. Failed job:

@RalfJung
Copy link
Copy Markdown
Member Author

Looks spurious. Let's try harder to get this landed today and unbreak out-of-tree drivers.
@bors retry p=10

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2026
@RalfJung
Copy link
Copy Markdown
Member Author

@bors p=10

@rust-bors

This comment has been minimized.

rust-bors bot pushed a commit that referenced this pull request Feb 26, 2026
Revert "Move aarch64-apple dist builder to dynamic llvm linking"



Reverts c033de9 (part of #152768) in order to fix  #153077.
@rust-bors rust-bors bot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 26, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Feb 26, 2026

💔 Test for af63d48 failed: CI. Failed job:

@JonathanBrouwer
Copy link
Copy Markdown
Contributor

@bors retry
Spurious

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2026
@rust-log-analyzer
Copy link
Copy Markdown
Collaborator

The job aarch64-gnu failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)
/dev/sda15       98M  6.4M   92M   7% /boot/efi
tmpfs           1.6G   16K  1.6G   1% /run/user/1001
================================================================================

Sufficient disk space available (120900848KB >= 52428800KB). Skipping cleanup.
##[group]Run src/ci/scripts/setup-environment.sh
src/ci/scripts/setup-environment.sh
shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
---
[RUSTC-TIMING] serde_value test:false 0.500
   Compiling toml v0.8.23
[RUSTC-TIMING] anstream test:false 0.375

Session terminated, killing shell...::group::Clock drift check
  local time: Thu Feb 26 08:02:52 UTC 2026
##[error]The runner has received a shutdown signal. This can happen when the runner service is stopped, or a manually started runner is canceled.
  network time: [RUSTC-TIMING] thiserror test:false 0.047
   Compiling url v2.5.7
[RUSTC-TIMING] serde_untagged test:false 0.249

@RalfJung
Copy link
Copy Markdown
Member Author

@bors retry The runner has received a shutdown signal

Wtf is happening with CI recently...

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors bot commented Feb 26, 2026

❗ You can only retry pull requests that are approved and have a previously failed auto build.

@RalfJung
Copy link
Copy Markdown
Member Author

Oh that was the same failure, the log analyzer was just slow.

rust-bors bot pushed a commit that referenced this pull request Feb 26, 2026
…uwer

Rollup of 7 pull requests

Successful merges:

 - #153079 (Revert "Move aarch64-apple dist builder to dynamic llvm linking")
 - #152651 (Avoid duplicate `requirement` diag args in `RegionOriginNote`)
 - #152978 (Port `#[rustc_autodiff]` to the attribute parser infrastructure)
 - #153091 (Migration of `LintDiagnostic` - part 4)
 - #153112 (Query key cleanups)
 - #153118 (mailmap: add redddy)
 - #153120 (Clean up some code related to `QueryVTable::execute_query_fn`)
@rust-bors rust-bors bot merged commit 7aa4f04 into rust-lang:main Feb 26, 2026
12 of 13 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Feb 26, 2026
rust-timer added a commit that referenced this pull request Feb 26, 2026
Rollup merge of #153079 - RalfJung:revert-macos-dyn, r=jieyouxu

Revert "Move aarch64-apple dist builder to dynamic llvm linking"

Reverts c033de9 (part of #152768) in order to fix  #153077.
@RalfJung RalfJung deleted the revert-macos-dyn branch March 3, 2026 08:42
vadorovsky added a commit to aya-rs/bpf-linker that referenced this pull request Apr 1, 2026
`rustc-llvm-proxy` used to work on musl targets by accident because
`LD_LIBRARY_PATH` let it `dlopen` our shared LLVM library.

After switching to `rpath`, that no longer works: our shared LLVM
library is not visible to `rustc-llvm-proxy`, and musl Rust toolchains
ship `libLLVM` statically, so there is no shared library for
`rustc-llvm-proxy` to load. This caused CI failures such as:

  unable to read dir /home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-musl/lib: No such file or directory (os error 2)
  thread 'test_link_ir_files' (4) panicked at /rustc/cf7da0b7277cad05b79f91b60c290aa08a17a6f0/library/core/src/panicking.rs:225:5:
  [...]
  unable to read dir /home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib: No such file or directory (os error 2)
  unable to read dir /root/.cargo/lib: No such file or directory (os error 2)
  thread 'test_link_ir_files' (4) panicked at /home/runner/work/bpf-linker/bpf-linker/bpf-linker/target/x86_64-unknown-linux-musl/debug/build/aya-rustc-llvm-proxy-5f163ea45ef44b54/out/llvm_gen.rs:14919:10:
  LLVMParseIRInContext2: DlSym { source: "Symbol not found: LLVMParseIRInContext2" }

The behavior on darwin targets is not reliable. Stable Rust toolchains
for macOS link `libLLVM` statically. Nightly tried to switch to dynamic
linking[0][1], but those attempts were reverted twice[2][3].

Prevent any related issues by excluding `default` and `rust-llvm-*`
features on darwin and musl targets.

[0] rust-lang/rust#152768
[1] rust-lang/rust#151063
[2] rust-lang/rust#153079
[3] rust-lang/rust#154485
vadorovsky added a commit to aya-rs/bpf-linker that referenced this pull request Apr 1, 2026
`rustc-llvm-proxy` used to work on musl targets by accident because
`LD_LIBRARY_PATH` let it `dlopen` our shared LLVM library.

After switching to `rpath`, that no longer works: our shared LLVM
library is not visible to `rustc-llvm-proxy`, and musl Rust toolchains
ship `libLLVM` statically, so there is no shared library for
`rustc-llvm-proxy` to load. This caused CI failures such as:

  unable to read dir /home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-musl/lib: No such file or directory (os error 2)
  thread 'test_link_ir_files' (4) panicked at /rustc/cf7da0b7277cad05b79f91b60c290aa08a17a6f0/library/core/src/panicking.rs:225:5:
  [...]
  unable to read dir /home/runner/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib: No such file or directory (os error 2)
  unable to read dir /root/.cargo/lib: No such file or directory (os error 2)
  thread 'test_link_ir_files' (4) panicked at /home/runner/work/bpf-linker/bpf-linker/bpf-linker/target/x86_64-unknown-linux-musl/debug/build/aya-rustc-llvm-proxy-5f163ea45ef44b54/out/llvm_gen.rs:14919:10:
  LLVMParseIRInContext2: DlSym { source: "Symbol not found: LLVMParseIRInContext2" }

The behavior on darwin targets is not reliable. Stable Rust toolchains
for macOS link `libLLVM` statically. Nightly tried to switch to dynamic
linking[0][1], but those attempts were reverted twice[2][3].

Prevent any related issues by excluding `default` and `rust-llvm-*`
features on darwin and musl targets.

[0] rust-lang/rust#152768
[1] rust-lang/rust#151063
[2] rust-lang/rust#153079
[3] rust-lang/rust#154485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Miri fails to link on macOS

8 participants