[DO NOT MERGE] Method receiver lint#152214
Draft
BennoLossin wants to merge 6 commits intorust-lang:mainfrom
Draft
[DO NOT MERGE] Method receiver lint#152214BennoLossin wants to merge 6 commits intorust-lang:mainfrom
BennoLossin wants to merge 6 commits intorust-lang:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is implementing the lint described in #151583. The plan is to run a crater run on this lint before deciding on how to add this to the language.
An important detail that I noticed when implementing was that it must recursively look at the target type. Since dereferencing to a concrete type that then derefs to a generic has the same problem.