[WIP] Check coroutine upvars and resume ty in dtorck constraint, this time based off of TypingMode#144158
Closed
compiler-errors wants to merge 2 commits intorust-lang:mainfrom
Closed
[WIP] Check coroutine upvars and resume ty in dtorck constraint, this time based off of TypingMode#144158compiler-errors wants to merge 2 commits intorust-lang:mainfrom
TypingMode#144158compiler-errors wants to merge 2 commits intorust-lang:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #144156, see the paragraph about a better approach.
This is broken until we start using
TypingMode::Borrowckunconditionally. This also has some perf implications, since there were a few places we were collapsingTypingMode::Borrowck { defining_opaque_types: [] }into a non-body analysis typing mode, which means we may have to go back to splitting the caching between these modes.