[compiletest-related cleanups 3/7] Make the distinction between sources root vs test suite sources root in compiletest less confusing#136474
Merged
bors merged 2 commits intorust-lang:masterfrom Feb 22, 2025
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference for overall changes: #136437
Part 3 of 7 of the
compiletest-related cleanups PR series.Summary
--src-basecompiletest in favor of new flags--src-rootand--src-test-suite-rootwhich more accurately conveys the intent.--src-basepreviously actually meant--src-test-suite-rootand has caused multiple confusions.--src-rootto have bootstrap directly feed source root path to compiletest, instead of doing a hacky directory parent search heuristic (find_rust_src_root) that somehow returns anOption<PathBuf>.Review advice
Best reviewed commit-by-commit.
r? bootstrap