Skip to content

[compiletest-related cleanups 3/7] Make the distinction between sources root vs test suite sources root in compiletest less confusing#136474

Merged
bors merged 2 commits intorust-lang:masterfrom
jieyouxu:src-base
Feb 22, 2025
Merged

Conversation

@jieyouxu
Copy link
Copy Markdown
Member

@jieyouxu jieyouxu commented Feb 3, 2025

Reference for overall changes: #136437
Part 3 of 7 of the compiletest-related cleanups PR series.

Summary

  • Remove --src-base compiletest in favor of new flags --src-root and --src-test-suite-root which more accurately conveys the intent. --src-base previously actually meant --src-test-suite-root and has caused multiple confusions.
  • Use --src-root to have bootstrap directly feed source root path to compiletest, instead of doing a hacky directory parent search heuristic (find_rust_src_root) that somehow returns an Option<PathBuf>.

Review advice

Best reviewed commit-by-commit.

r? bootstrap

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants