Introduce CoercePointeeValidated for coherence checks at typeck stage#136107
Merged
bors merged 6 commits intorust-lang:masterfrom Feb 11, 2025
Merged
Introduce CoercePointeeValidated for coherence checks at typeck stage#136107bors merged 6 commits intorust-lang:masterfrom
bors merged 6 commits intorust-lang:masterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #135206
This is the first PR to introduce the "wellformedness" check for
derive(CoercePointee).This patch introduces a new error code to cover all the prerequisites of the said macro. The checks that is enforced with this patch is whether the data is indeed
structand whether the layout is set torepr(transparent).A following series of patch will arrive later to address the following concern.
An open question is whether there is a good schema to encode the
#[pointee]as well, so that we could also check if the#[pointee]type parameter is indeed?Sized.@rustbot label F-derive_coerce_pointee