Orphanck: Reject uncovered opaque types#135910
Draft
fmease wants to merge 3 commits intorust-lang:mainfrom
Draft
Orphanck: Reject uncovered opaque types#135910fmease wants to merge 3 commits intorust-lang:mainfrom
fmease wants to merge 3 commits intorust-lang:mainfrom
Conversation
fmease
added
S-waiting-on-author
rustbot
added
S-waiting-on-review
fmease
commented
Jan 23, 2025
Comment on lines
+524
to
+527
| // FIXME(fmease): This is a temporary HACK; rework it. In the next solver, | ||
| // we normalize structurally meaning opaque types "remain behind" weak | ||
| // aliases. I kind of want to expand_weak_alias_tys this but that's | ||
| // pretty hacky, too. |
Member
Author
There was a problem hiding this comment.
The HACK mentioned in the PR description.
Contributor
There was a problem hiding this comment.
Yeah 🤔 I don't really know what to do here. I feel like ideally we potentially don't need to recompute things here and report an error using only the original uncovered type as this folder is somewhat :/
I am personally fine with slightly regressing diagnostics here if necessary for that, but don't have a clear idea of how bad this would be
fmease
removed
the
S-waiting-on-review
fmease
commented
Jan 23, 2025
| ControlFlow::Break(OrphanCheckEarlyExit::LocalTy(ty)) | ||
| } | ||
| } else { | ||
| // Regarding *opaque types* specifically, we choose to treat them as non-local, |
Member
Author
There was a problem hiding this comment.
We probably want to bring back some of these nicely written points.
This comment was marked as resolved.
This comment was marked as resolved.
lcnr
reviewed
Jan 28, 2025
fmease
force-pushed
the
orphanck-rej-uncovered-opaques
branch
5 times, most recently
from
21c0272 to
aba5f47
Compare
This comment was marked as resolved.
This comment was marked as resolved.
fmease
force-pushed
the
orphanck-rej-uncovered-opaques
branch
from
aba5f47 to
111194c
Compare
fmease
force-pushed
the
orphanck-rej-uncovered-opaques
branch
from
111194c to
41273fc
Compare
Contributor
|
☔ The latest upstream changes (presumably #152213) made this pull request unmergeable. Please resolve the merge conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #130978.
Fixes #136188.
TODO: Fix blocking
FIXME(fmease)s.TODO: Clean up tests.
Feel free to review already though!
r? lcnr