Skip to content

return both matching braces - #23026

Open
bend-n wants to merge 1 commit into
rust-lang:masterfrom
bend-n:matching_brace_returns_pair
Open

return both matching braces#23026
bend-n wants to merge 1 commit into
rust-lang:masterfrom
bend-n:matching_brace_returns_pair

Conversation

@bend-n

@bend-n bend-n commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

so, this is technically the same behavior as simply calling a matching brace on the result of itself, but it saves a request, and the result is trivially computable, so you may as well return both? this makes it trivial to implement "remove brackets" behavior.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 4, 2026
@bend-n
bend-n force-pushed the matching_brace_returns_pair branch from 56df38d to 5ef0408 Compare August 4, 2026 09:59

@ChayimFriedman2 ChayimFriedman2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't change the TypeScript extension.

Also, I'm not sure we want this. @rust-lang/rust-analyzer?

View changes since this review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants