feat: Support #[doc(hidden)] #[macro_export] macro_rules! that are reexported in a place different than the crate root - #22234
Open
ChayimFriedman2 wants to merge 3 commits into
Conversation
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
force-pushed
the
macro-export-hidden
branch
from
May 1, 2026 04:46
0f32a79 to
d9a3d75
Compare
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
macro-export-hidden
branch
from
May 1, 2026 07:54
d9a3d75 to
570b466
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
macro-export-hidden
branch
from
May 23, 2026 21:00
570b466 to
d3385c2
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
macro-export-hidden
branch
from
July 7, 2026 15:42
d3385c2 to
6d0fab1
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ChayimFriedman2
force-pushed
the
macro-export-hidden
branch
from
July 19, 2026 13:51
6d0fab1 to
6980753
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…rted in a place different than the crate root With some limitations forced on us by the analyzer, as explained in the code.
ChayimFriedman2
force-pushed
the
macro-export-hidden
branch
from
August 9, 2026 06:09
6980753 to
48b80a1
Compare
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With some limitations forced on us by the analyzer, as explained in the code.
Closes #20678 to the best we can. googletest macros' exports are actually not in the same module, so they will need to change that.
Closes #21469.