Update deprecated to use the attribute template#1891
Open
ehuss wants to merge 7 commits intorust-lang:masterfrom
Open
Update deprecated to use the attribute template#1891ehuss wants to merge 7 commits intorust-lang:masterfrom
deprecated to use the attribute template#1891ehuss wants to merge 7 commits intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
This rewords the intro to be more general, as the details will be included in separate rules. This also moves the example into the intro.
Looking at the RFC, it doesn't seem like it offers any particular insight or motivation that isn't already clear from what the attribute does. We still need a policy for how we refer to historical information like this, but generally I'd lean away from it.
This is somewhat separate behavior, and I think it helps to discuss it separately.
This updates it to use the attribute template format, and to split the behaviors of the different forms into different rules so they can be referenced.
Support for this was added in rust-lang/rust#77118
More closely align with the template, and some minor word tweaks.
Collaborator
|
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New rules:
attributes.diagnostics.deprecated.duplicatesattributes.diagnostics.deprecated.behaviorattributes.diagnostics.deprecated.generic-messageattributes.diagnostics.deprecated.messageattributes.diagnostics.deprecated.fieldsattributes.diagnostics.deprecated.containersRenamed rules:
attributes.diagnostic.deprecated.allowed-positionsis nowattributes.diagnostics.deprecated.allowed-positions(fixed typo)