[codex] add optional mock labels - #142
Open
Old-Ding wants to merge 2 commits into
Open
Conversation
Old-Ding
marked this pull request as ready for review
June 29, 2026 16:56
newAM
requested changes
Jul 12, 2026
Allow tests with multiple mocks to identify the failing instance in expectation errors. Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
Old-Ding
force-pushed
the
codex/add-mock-labels
branch
from
July 12, 2026 17:29
4c3a887 to
1353f86
Compare
Preserve existing unlabeled panic messages while appending labels at the shared expectation-consumption layer. Route ADC and both I2C implementations through it and add regression coverage. Signed-off-by: Old-Ding <35417409+Old-Ding@users.noreply.github.com>
Author
|
Addressed on the current head ( Verification on the current head:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #43.
This adds optional labels to the generic mock state so missing-expectation failures can identify which mock instance failed when a test uses several mocks at once. Unlabeled mocks retain their existing panic messages.
Changes
Generic::with_label(expected, label)while keepingGeneric::new(expected)unchanged.next_expectation(message)helper that appends the label to the existing missing-expectation message when present.Validation
Local checks passed:
cargo test --all-features(145 unit tests and 21 doc tests)cargo +1.75.0 test --all-features(145 unit tests and 21 doc tests)cargo fmt --all -- --checkgit diff --check