Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(build): match local Python by default and add 3.13 #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
feat(build): match local Python by default and add 3.13 #330
Changes from all commits
983ef3e4fe6f9728d3f584b366ca12a238eFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[🟡 Medium] [🔵 Bug]
The updated docs state that
--python-versionoverrides per-resource declarations, but the resolver explicitly raisesValueErrorwhen an override conflicts with any declared resourcepython_version. This mismatch can cause users to expect forced overrides and then hit hard build/deploy failures. Reword these option docs to describe precedence with conflict validation (not unconditional override) in both build and deploy docs.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[🟡 Medium] [🔵 Bug]
This patch adds a second assignment block for key constants (
SUPPORTED_PYTHON_VERSIONS,DEFAULT_PYTHON_VERSION, and version-set aliases) while the original assignments remain above, creating silent shadowing and multiple sources of truth. Even with identical values today, future edits to the first block can appear correct but have no runtime effect. Keep a single canonical definition per constant.Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.