update gradle version in script plugin template#19
Closed
Conversation
chrismcg14
approved these changes
Jul 24, 2023
fdevans
added a commit
that referenced
this pull request
Feb 3, 2026
PR #19 tried to pin to gradle-5.6 branch, but analysis shows: - gradle-5.6 branch: Last updated April 2021 (unmaintained) - master branch: Last updated October 2025 (actively maintained) Master branch has modern features: - Reproducible builds for security - Modern Gradle syntax - Active maintenance Decision: Keep master with security warning comments (already added) This supersedes PR #19 which should be closed as outdated. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Thanks for this PR! However, after analysis, we're going to keep using the Reason: The
The
Our approach: We've addressed the supply chain security concern by adding warning comments to all script plugin templates that load remote Gradle scripts. This makes developers aware of the risk while keeping the benefits of the actively maintained This PR is now superseded by PR #22 (release 1.2.0). Recommend closing this PR as outdated. See commit: a6b5ee2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.