Skip to content

Fix Python 3.14 compatibility in dirhash job count - #49

Open
biofotis wants to merge 1 commit into
ruffsl:masterfrom
botsandus:master
Open

Fix Python 3.14 compatibility in dirhash job count#49
biofotis wants to merge 1 commit into
ruffsl:masterfrom
botsandus:master

Conversation

@biofotis

Copy link
Copy Markdown

This PR is making the script compatible with python 3.14 that is used by default in Ubuntu resolute

@biofotis

Copy link
Copy Markdown
Author

@ruffsl We fixed this in our fork but it will be needed for people working on latest ubuntu and Lyrical ros

@SteveMacenski

Copy link
Copy Markdown

We're experiencing this issue as well in Nav2 - I patched it in CI via

# Patch colcon-cache for Python 3.14 compatibility
pip install --break-system-packages --force-reinstall --no-deps git+https://github.com/ruffsl/colcon-cache.git@master
DIRHASH_FILE=$(python3 -c "import colcon_cache.task.lock.dirhash as m; print(m.__file__)")
sed -i 's/modifier_group = parser.add_mutually_exclusive_group()/modifier_group = parser/' "$DIRHASH_FILE"
sed -i 's/jobs = max(filter(None.__ne__, \[1, jobs\]))/jobs = max(j for j in (1, jobs) if j is not None)/' "$DIRHASH_FILE"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants