Add cost cents to events #611
Open
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maebeale
approved these changes
Dec 31, 2025
Collaborator
maebeale
left a comment
maebeale
left a comment
There was a problem hiding this comment.
Looks great! Solid thinking re nil vs 0!
I know this is just the db, but will prob be a good idea to add a validation like this to the model when you go to add it and cost_cents to strong_params.
validates :cost_cents, numericality: { greater_than_or_equal_to: 0 }, allow_nil: true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
And add a field to the event model to capture the amount the event could cost.
At this point, I opted to allow null values and default to null to distinguish between events with an unassigned cost (NULL) and a free event (0 cents).
Another baby PR to get. my feet wet. Thanks for any feedback