Repository navigation
Conversation
URI.parse accepts query headers without a value (for example ?Subject or ?body&cc=...), so set_headers stored a one-element array. to_mailtext then called decode_www_form_component(nil) and raised NoMethodError. Normalize missing header values to "" when parsing, and treat a nil to address as empty when building the mailtext.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
URI.parse("mailto:ruby-list@ruby-lang.org?Subject").to_mailtextraisesNoMethodErrorbecause a header with no value is stored as["Subject"]and then decoded asnil.I updated
set_headersto use""for missing values, andto_mailtextstringifies so a nil address is treated as empty. I also added a test for this case.