Repository navigation
Fix rust build on arm64 Linux, where C char is unsigned - #4245
Merged
Merged
Conversation
Options#build_options cast each scope local's pointer to `*const i8`
before passing it to pm_string_constant_init. bindgen generates the
parameter as `*const c_char`, which is `i8` on x86 Linux, macOS and
Windows but `u8` on Linux ARM, so the crate failed to compile there:
error[E0308]: mismatched types
--> ruby-prism/src/lib.rs:306:64
expected `*const u8`, found `*const i8`
Use `.cast()` and let the type be inferred from the bindings instead.
CI only builds on platforms where char is signed, which is why this
went unnoticed.
kddnewton
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Options#build_options cast each scope local's pointer to
*const i8before passing it to pm_string_constant_init. bindgen generates the parameter as*const c_char, which isi8on x86 Linux, macOS and Windows butu8on Linux ARM, so the crate failed to compile there:Use
.cast()and let the type be inferred from the bindings instead. CI only builds on platforms where char is signed, which is why this went unnoticed.