Reduce size of the WASM file (2M->480K) #3824
Merged
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@kddnewton Awesome. All of these settings I believe also are the same to allow the parser implementation work compiled with Chicory (from what I recall). |
marcoroth
added a commit
to marcoroth/herb
that referenced
this pull request
Jan 17, 2026
This pull request applies size optimizations to the WebAssembly build, inspired by ruby/prism#3824. The WASM bindings don't use Prism's prettyprint, JSON serialization, or pack parsing features, so we can exclude these features by defining `PRISM_EXCLUDE_PRETTYPRINT`, `PRISM_EXCLUDE_JSON`, and `PRISM_EXCLUDE_PACK`. Added `-Oz` (optimize for size), `-g0` (strip debug info), `-flto` (link-time optimization), and `-fdata-sections -ffunction-sections` (enable dead code elimination) to produce smaller output. Excluded `ruby_parser.c` from the WASM build since it's only used for CLI debugging. **Results** | Build | Before | After | Reduction | | --- | --- | --- | --- | | Browser | 905K | 365K | -540K (~60%) | | Node | 907K | 365K | -542K (~60%) | <details> <summary>Details</summary> **Before:** ``` ls -lh javascript/packages/browser/build/libherb.js javascript/packages/node-wasm/build/libherb.js -rw-r--r--@ 1 marcoroth staff 905K Jan 17 11:17 javascript/packages/browser/build/libherb.js -rw-r--r--@ 1 marcoroth staff 907K Jan 17 11:17 javascript/packages/node-wasm/build/libherb.js ``` **After:** ``` ls -lh javascript/packages/browser/build/libherb.js javascript/packages/node-wasm/build/libherb.js -rw-r--r--@ 1 marcoroth staff 365K Jan 17 11:18 javascript/packages/browser/build/libherb.js -rw-r--r--@ 1 marcoroth staff 365K Jan 17 11:18 javascript/packages/node-wasm/build/libherb.js ``` </details>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.