Repository navigation
Fix inline reference renumbering - #796
Merged
Merged
Conversation
ydah
force-pushed
the
fix/inline-reference-renumbering
branch
from
September 4, 2026 12:18
6daf08d to
08ab4a3
Compare
ydah
force-pushed
the
fix/inline-reference-renumbering
branch
from
September 4, 2026 12:55
08ab4a3 to
697082c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline::Resolver#replace_user_coderenumbered positional references with repeated global substitutions. A reference shifted by one substitution could be shifted again,$1could match the prefix of$10, location references could be renumbered incorrectly, and backslashes in an inline action could be interpreted as replacement backreferences.Replace each parsed reference exactly once, in reverse source order using its column range, following the same position-based strategy as
Grammar::Code#translated_code.Add regression coverage for multiple
$nand@nreferences, multi-digit references, and backslashes in inline actions.