Repository navigation
test: keep stub server-manifest cache out of the repository root - #156
Merged
Merged
Conversation
commit: |
Contributor
Benchmark results
|
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The shared Rsbuild API mock in
tests/setup.tshad nocontext.cachePath, so the server-manifest stamp resolved under the current working directory, and every test run wrotereact-router/<hash>/server-manifest.jsoninto the repository root. One of those files was committed tomainin #152.The mock now uses Rsbuild's default
node_modules/.cache, which is gitignored, and this removes the committed stub. It never shipped: the package only publishesdistandsrc.Test-only change, so there's no changeset.