Python3, dependency updates, encryption changes#12
Open
Kenneth-W-Chen wants to merge 37 commits intorossem:masterfrom
Open
Python3, dependency updates, encryption changes#12Kenneth-W-Chen wants to merge 37 commits intorossem:masterfrom
Kenneth-W-Chen wants to merge 37 commits intorossem:masterfrom
Conversation
…tion instead of original
Signed-off-by: Kenneth-W-Chen <74205780+Kenneth-W-Chen@users.noreply.github.com>
Signed-off-by: Kenneth-W-Chen <74205780+Kenneth-W-Chen@users.noreply.github.com>
Signed-off-by: Kenneth-W-Chen <74205780+Kenneth-W-Chen@users.noreply.github.com>
Signed-off-by: Kenneth-W-Chen <74205780+Kenneth-W-Chen@users.noreply.github.com>
Signed-off-by: Kenneth-W-Chen <74205780+Kenneth-W-Chen@users.noreply.github.com>
Signed-off-by: Kenneth-W-Chen <74205780+Kenneth-W-Chen@users.noreply.github.com>
Signed-off-by: Kenneth-W-Chen <74205780+Kenneth-W-Chen@users.noreply.github.com>
Signed-off-by: Kenneth-W-Chen <74205780+Kenneth-W-Chen@users.noreply.github.com>
Signed-off-by: Kenneth-W-Chen <74205780+Kenneth-W-Chen@users.noreply.github.com>
Signed-off-by: Kenneth-W-Chen <74205780+Kenneth-W-Chen@users.noreply.github.com>
Author
|
I'll be adding more comments/documentation over the next few weeks (unless PR gets approved) |
Changed the bit about some filenames not appearing to how Reddit's search tool doesn't update indexes for a bit
…ome documentation Signed-off-by: Kenneth-W-Chen <74205780+Kenneth-W-Chen@users.noreply.github.com>
Kenneth-W-Chen
commented
Apr 12, 2023
Author
There was a problem hiding this comment.
I want to say a1b22ea will make it slightly faster because we don't have to load the entire file into memory and then encrypt it, with both the ciphertext and plaintext stored at once
Author
|
I'm guessing that rossem isn't maintaining this repo anymore since there's been an open PR since 2018. I will not be pushing to this PR/branch any further. I'll be pushing to my fork for now here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lot's changed with Python and the various packages used by this program since it was last updated. A summary of what I changed:
(or so my friend says)print, bytes being a separate type from string, etc.)praw.iniorredditglobals.py.RedditStorage.py. Mainly did that because to make it easier to see how the script is started.