Added LeadLag controller#60
Conversation
cfc9a91 to
2707516
Compare
|
This also partially addresses issue #35 |
|
7d41086 to
d1f205e
Compare
|
@bmagyar I just squashed all the commits into one. |
|
The latest commit refers to issue #61 (would have preferred to branch them out, but I guess it's a little bit too late now). |
|
Hello, Thanks for the pr! Some (very) minor notes about the documentation :)
Thanks again! 👍 |
| void Pid::getCurrentPIDErrors(double *pe, double *ie, double *de) | ||
| { | ||
| // Get the gain parameters from the realtime buffer | ||
| Gains gains = *gains_buffer_.readFromRT(); |
|
It's never not too late to branch it out. You can easily roll back your PR branch to the previous commit and make a force push. I'd merge the travis update on the separate PR. You should be able to change the Pull Request target to kinetic-devel. |
|
@progtologist Could you please rebase this PR against kinetic? Now we've got travis working again |
|
I will try to do it this weekend and update you ;) |
|
@progtologist this is a kind ping. I'd like to merge this, believe me :) |
|
I am closing this PR in favor of #68 (switched to kinetic, created separate feature branch to avoid polution if another fix emerges) |
This PR should be able to be integrated in any version(branch), I am currently using indigo so I have only tested it against that.