Add option to install ROMs flat - #129
Merged
Merged
Conversation
matthew-pye
commented
Jul 27, 2026
Contributor
- Add option to install ROM flat instead of installing ROMs in a folder with the same name as the game
Member
Contributor
Greptile SummaryAdds a per-emulator option for storing ROM files directly in the configured destination.
Confidence Score: 2/5This PR is not safe to merge because routine failure cleanup or uninstall can delete every ROM in a flat destination, and archive installs can attach sibling files to the wrong game. The new flat mode replaces the game-specific install directory with a shared mapping root while downstream cleanup, uninstall, and ROM discovery continue treating that path as exclusively owned by one game. Files Needing Attention: Games/RomMInstallController.cs and Games/RomMImport.cs Important Files Changed
Prompt To Fix All With AIFix the following 2 code review issues. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 2
Games/RomMInstallController.cs:51-52
**Shared root is recursively deleted**
When a flat installation fails, is cancelled, or is later uninstalled, the shared destination is treated as the game's private install directory and recursively deleted, causing every sibling ROM in that destination to be removed.
### Issue 2 of 2
Games/RomMInstallController.cs:51-52
**ROM discovery includes sibling games**
When an archive is installed into a flat destination containing other supported ROM files, `BuildRoms` recursively scans the shared directory and adds those sibling files to the newly installed game's launch targets.
Reviews (1): Last reviewed commit: "Add install flat option" | Re-trigger Greptile |
gantoine
self-requested a review
July 27, 2026 13:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.