Merged
Conversation
The optimization replaced `all(k not in prediction for k in ["top", "predicted_classes"])` with a direct boolean expression `("top" not in prediction and "predicted_classes" not in prediction)` in `is_prediction_registration_forbidden`, eliminating generator overhead and reducing that function's profiled time from 70.7% to 24% of its own cost. This hot helper is called on every datapoint registration (1125 calls in the profiler), so removing the generator iteration yields a cumulative ~4.7 ms speedup across all invocations, driving the overall 15% runtime improvement from 6.24 ms to 5.39 ms.
Co-authored-by: codeflash-ai[bot] <148906541+codeflash-ai[bot]@users.noreply.github.com>
digaobarbosa
requested review from
PawelPeczek-Roboflow,
dkosowski87,
grzegorz-roboflow,
hansent,
probicheaux and
yeldarby
as code owners
PawelPeczek-Roboflow
approved these changes
Mar 17, 2026
grzegorz-roboflow
approved these changes
Mar 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The billing for RTSP and MJPEG were being charged as images instead of video hosting.
Type of Change
Testing
Checklist
Additional Context