Skip to content

Count wide back-wall rebounds as backboard bounces#266

Merged
colonelpanic8 merged 1 commit into
masterfrom
colonelpanic/wide-backboard-double-tap
Jul 2, 2026
Merged

Count wide back-wall rebounds as backboard bounces#266
colonelpanic8 merged 1 commit into
masterfrom
colonelpanic/wide-backboard-double-tap

Conversation

@colonelpanic8

Copy link
Copy Markdown
Contributor

Summary

  • widen backboard-bounce detection to include full back-wall/corner reads instead of only central backboard bounces
  • add a regression test for a wide high back-wall rebound that should arm double-tap detection

Root cause

The backboard-bounce detector capped rebounds at abs(x) <= 1600, so wide back-wall reads could never produce the upstream backboard event needed by the double_tap and double_tap_goal paths.

Validation

  • cargo fmt --check
  • cargo test -p subtr-actor backboard_bounce::tests
  • cargo test -p subtr-actor double_tap::tests
  • cargo test -p subtr-actor --test clip_double_tap_test
  • just check

@colonelpanic8 colonelpanic8 merged commit e7cfdb4 into master Jul 2, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant