Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/lib-review-loop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ $prompt"
# $1 — prompt text
run_gemini() {
local prompt="$1"
echo "$prompt" | gemini -p " " --yolo --allowed-mcp-server-names "" \
echo "$prompt" | gemini -p " " --yolo --allowed-mcp-server-names "__none__" \
2> >(grep -v -E 'Warning:.*deprecated|YOLO mode|Session cleanup disabled|Loaded cached credentials' >&2)
}

Expand Down
12 changes: 12 additions & 0 deletions setup
Original file line number Diff line number Diff line change
Expand Up @@ -503,6 +503,14 @@ configure_claude_settings() {
if ! echo "$settings" | jq -e '.env.CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS' &>/dev/null; then
feature_changes+=("teams")
fi
if ! echo "$settings" | jq -e '.env.CLAUDE_CODE_NO_FLICKER' &>/dev/null; then
feature_changes+=("noflicker")
fi
if [[ "$(uname -s)" == MINGW* || "$(uname -s)" == MSYS* || "$(uname -s)" == CYGWIN* ]]; then
if ! echo "$settings" | jq -e '.env.CLAUDE_CODE_USE_POWERSHELL_TOOL' &>/dev/null; then
feature_changes+=("powershell")
fi
fi

# ── Check read-only permissions (batch jq, handles legacy :* format) ──
local perms_json
Expand Down Expand Up @@ -533,6 +541,8 @@ configure_claude_settings() {
websearch) echo -e " • ${BOLD}WebSearch${NC} — allow web searches without prompting" ;;
attribution) echo -e " • ${BOLD}attribution${NC} — disable commit/PR attribution tags" ;;
teams) echo -e " • ${BOLD}CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS=1${NC} — enable agent teams" ;;
noflicker) echo -e " • ${BOLD}CLAUDE_CODE_NO_FLICKER=1${NC} — flicker-free fullscreen rendering" ;;
powershell) echo -e " • ${BOLD}CLAUDE_CODE_USE_POWERSHELL_TOOL=1${NC} — enable native PowerShell tool" ;;
esac
done
echo ""
Expand All @@ -543,6 +553,8 @@ configure_claude_settings() {
websearch) updated=$(echo "$updated" | jq '.permissions.allow = ((.permissions.allow // []) + ["WebSearch"])') ;;
attribution) updated=$(echo "$updated" | jq '.attribution = {"commit": "", "pr": ""}') ;;
teams) updated=$(echo "$updated" | jq '.env = ((.env // {}) + {"CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS": "1"})') ;;
noflicker) updated=$(echo "$updated" | jq '.env = ((.env // {}) + {"CLAUDE_CODE_NO_FLICKER": "1"})') ;;
powershell) updated=$(echo "$updated" | jq '.env = ((.env // {}) + {"CLAUDE_CODE_USE_POWERSHELL_TOOL": "1"})') ;;
esac
done
changed=true
Expand Down
20 changes: 18 additions & 2 deletions test/smoke
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,21 @@ run_smoke_test() {

# Check if we timed out
if [[ $elapsed -ge $TIMEOUT ]]; then
# Gemini retries indefinitely on rate limits. Only skip when the
# output shows positive rate-limit evidence; otherwise fall through
# so real hangs/regressions still fail the smoke test.
if [[ "$agent" == "gemini" ]] && [[ -f "$output_file" ]] && \
grep -qE -i 'rate[- ]?limit|resource_exhausted|quota|(^|[^0-9])429([^0-9]|$)' "$output_file"; then
echo -e " ${YELLOW}SKIP${NC} $name (rate-limited)"
RESULTS+=("SKIP $name (rate-limited)")
((SKIPPED++))
return 0
fi
echo -e " ${YELLOW}TIMEOUT${NC} $name (>${TIMEOUT}s)"
if [[ -f "$output_file" ]]; then
echo " --- last 5 lines of output ---"
tail -5 "$output_file" | sed 's/^/ /'
fi
RESULTS+=("TIMEOUT $name")
((FAIL++))
return 1
Expand Down Expand Up @@ -276,6 +290,8 @@ Edit only the divide function. Do not create new files."
REVIEWER_TOOLS="Read,Write,Bash,Grep,Glob"
EDITOR_TOOLS="Edit,Read,Write,Bash,Grep,Glob"

SKIPPED=0

# ---- run tests -----------------------------------------------------------

for agent in "${agents[@]}"; do
Expand All @@ -297,10 +313,10 @@ done

# ---- summary -------------------------------------------------------------

total=$((PASS + FAIL))
total=$((PASS + FAIL + SKIPPED))
echo ""
echo "==========="
echo "Results: $PASS passed, $FAIL failed out of $total tests"
echo "Results: $PASS passed, $FAIL failed, $SKIPPED skipped out of $total tests"
echo ""

for r in "${RESULTS[@]}"; do
Expand Down
Loading