Skip to content

refactor: remove redundant tests and dead code - #5

Merged
eersnington merged 8 commits into
mainfrom
refactor/remove-redundant-code
Oct 29, 2026
Merged

eersnington merged 8 commits into
mainfrom
refactor/remove-redundant-code

Conversation

@eersnington

Copy link
Copy Markdown
Member
  • Makes the backfill resume test prove it resumes: it now fails if the client ignores startAt. Before, it passed either way.
  • Removes tests that repeat other tests, and an assertion that could never fail. Merges two overlapping backfill failure tests into one.
  • Moves the second-export alarm check into the existing "after migration" test, where it still catches the bug fixed in fix(worker): keep the alarm when an object is exported again #4.
  • Removes an unreachable loop condition and return in worker.ts, and fixes a wrong comment about when __migrator is created.
  • Shares the snapshot helper between the tests and the smoke script, and type-checks the smoke script.
  • Removes unused example options, a redundant tsconfig exclude, a wrong guide snippet, and a stale Miniflare mention.

@eersnington
eersnington merged commit 4715936 into main Oct 29, 2026
1 check passed
@eersnington
eersnington deleted the refactor/remove-redundant-code branch October 29, 2026 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant