Skip to content

fix(worker): stop alarms on migrated durable objects - #2

Merged
eersnington merged 1 commit into
mainfrom
fix/stop-alarms-after-migration
Oct 28, 2026
Merged

fix(worker): stop alarms on migrated durable objects#2
eersnington merged 1 commit into
mainfrom
fix/stop-alarms-after-migration

Conversation

@eersnington

@eersnington eersnington commented Oct 28, 2026

Copy link
Copy Markdown
Member
  • Removes a Durable Object's pending alarm when it is marked migrated, so scheduled work can never run on the old copy. The new server already gets the alarm time in __do_meta.
  • Saves the alarm time, and sets it again when MIGRATOR_DISABLED=true and the object next starts. Before this, an alarm that came due during a migration was swallowed and lost on rollback.
  • Adds a test that rolls back after an alarm's time has passed and checks that the alarm still runs.
  • Documents the alarm behaviour in the guide's rollback section.

@eersnington
eersnington marked this pull request as ready for review October 28, 2026 23:12
@eersnington
eersnington merged commit 4b99421 into main Oct 28, 2026
1 check passed
@eersnington
eersnington deleted the fix/stop-alarms-after-migration branch October 28, 2026 23:14
@eersnington eersnington mentioned this pull request Oct 29, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@eersnington