Remove x-user-email from audit logs; add test#858
Merged
Conversation
|
@martinshub-tech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this pr closes #729
Description
This PR addresses a privacy compliance issue by eliminating the logging of raw email addresses in the audit system.
Changes Made
Audit Middleware (src/middleware/audit.ts)
Removed the fallback that reads x-user-email from request headers.
Actor identification now relies solely on x-admin-user or x-user-id, falling back to 'anonymous'.
Updated comments to reflect the new behavior.
Tests (tests/audit.test.ts)
Added a unit test that:
Sends a request with x-user-id.
Calls logAuditMutation.
Asserts that the actorId in the generated audit entry does not contain an “@” character and exactly matches the provided user ID.