Skip to content

fix: remove duplicate CH region code in RegionCode type#855

Merged
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
lamborghini21:fix/duplicate-ch-region-code
Jun 29, 2026
Merged

fix: remove duplicate CH region code in RegionCode type#855
RUKAYAT-CODER merged 1 commit into
rinafcode:mainfrom
lamborghini21:fix/duplicate-ch-region-code

Conversation

@lamborghini21

Copy link
Copy Markdown
Contributor

Summary

Fixes #715 — duplicate CH region code in src/locales/types.ts was
causing silent overwrite during locale resolution for Switzerland.

Changes

  • Removed duplicate CH entry under German regions in RegionCode type
  • Replaced it with LI (Liechtenstein) which is the correct German-speaking region
  • Added unit test in src/locales/config.test.ts to assert all region codes are unique

Testing

  • pnpm test src/locales/config.test.ts → ✅ 1 passed
  • pnpm run check-locales → ✅ exits with code 0

Acceptance Criteria

  • RegionCode contains no duplicate values
  • check-locales script exits with code 0
  • Swiss region resolves to the expected locale

Closes #715

@drips-wave

drips-wave Bot commented Jun 29, 2026

Copy link
Copy Markdown

@lamborghini21 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@RUKAYAT-CODER

Copy link
Copy Markdown
Contributor

Thank you for contributing to the project.

@RUKAYAT-CODER RUKAYAT-CODER merged commit 9fa9709 into rinafcode:main Jun 29, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Duplicate CH region code in locales config causes unexpected locale resolution

2 participants