fix(security): rate limit /api/errors/report to prevent log-flooding DoS#854
Merged
RUKAYAT-CODER merged 1 commit intoJun 29, 2026
Merged
Conversation
Add a dedicated REPORTING rate-limit tier (10 req/min per IP) and apply withRateLimit at the top of the error-report POST handler. Requests over the limit return HTTP 429 with a Retry-After header; legitimate reports within the limit are accepted and logged. Rate-limit headers are attached to all responses. Closes rinafcode#721
|
@3m1n3nc3 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
|
Thank you for contributing to the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/api/errors/reportaccepted error reports from client-side JS with no rate limiting, leaving it open to log-flooding DoS — an attacker could script thousands of requests/sec, flooding the logging system and exhausting in-memory log buffers.This adds per-IP rate limiting to the endpoint.
Changes
REPORTINGrate-limit tier (src/lib/ratelimit.ts) — 10 req/min per IP, a lower tier suited to unauthenticated, client-driven endpoints prone to flooding abuse.src/app/api/errors/report/route.ts) —withRateLimit(request, 'REPORTING')runs at the top of the POST handler and short-circuits with HTTP 429 (including aRetry-Afterheader) before any work is done. Accepted responses also carryX-RateLimit-*headers viaaddHeaders.src/app/api/errors/report/__tests__/route.test.ts) — cover over-limit → 429, presence ofRetry-After, legitimate reports within the limit accepted, and per-IP isolation.Acceptance criteria
Retry-Afterheader is present in the 429 responseTesting
tsc --noEmit: no type errors in changed filesCloses #721