Skip to content

Bug/361 wallet connection transaction history#800

Merged
RUKAYAT-CODER merged 5 commits into
rinafcode:mainfrom
dot-enny:bug/361-wallet-connection-transaction-history
Jun 28, 2026
Merged

Bug/361 wallet connection transaction history#800
RUKAYAT-CODER merged 5 commits into
rinafcode:mainfrom
dot-enny:bug/361-wallet-connection-transaction-history

Conversation

@dot-enny

Copy link
Copy Markdown
Contributor

Description

This PR fixes a ReferenceError in the Web3 wallet connection hook and resolves a state leakage bug where transaction history could persist across different wallet connections.

Key changes:

  • Imported the missing walletConnectionQueue in src/hooks/useWeb3Wallet.ts to resolve the ReferenceError: walletConnectionQueue is not defined.
  • Fixed a test deadlock bug in useWeb3Wallet.test.ts (concurrent connect calls test) by utilizing vi.runAllTimersAsync() inside an async act() block.
  • Updated TransactionManager.tsx to reset the txHistory state to [] if the wallet is disconnected or when there is no saved history for the active address, preventing transaction history from leaking between sessions.
  • Added comprehensive unit tests in src/components/web3/__tests__/TransactionManager.test.tsx to verify loading and clearing of transaction history.

Related Issue

Closes #361

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • No console errors
  • Uses Lucide icons consistently
  • Responsive design implemented
  • Starknet best practices followed

@drips-wave

drips-wave Bot commented Jun 27, 2026

Copy link
Copy Markdown

@dot-enny Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@RUKAYAT-CODER

Copy link
Copy Markdown
Contributor

Thank you for contributing to the project.

@RUKAYAT-CODER RUKAYAT-CODER merged commit e55838e into rinafcode:main Jun 28, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug: Wallet Connection : Transaction History

2 participants