Repository navigation
Conversation
…s without operating-state labels #153 drew the kept-vs-removed and kept-only operating-curve figures for every reference turbine; the C3 merge dropped both, since a labelled run draws its used and unused records as the uplift-validity scatters instead. A toggle run carries no operating-state labels, so it was left with neither view of which rows, its references' included, fed the estimate. Both figures are back, per turbine and in the valid-records stage, and stay off for a labelled run. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Restores
plot_ops_curves(kept vs removed by the row filter) andplot_ops_curves_kept(kept rows only), drawn for the test turbine and each plotted reference, as #153 had them. They now write to the11_valid_recordsstage and return nothing when the SCADA frame carriesoperating_statelabels.Why
C3 (54addaf, carried into v1 by #143) removed both figures in favour of the uplift-validity scatters (
plot_run_uplift_validity). Those scatters need the operating-state labels that only the prepost harness adds.ToggleSpecialistMethodhandswrite_common_diagnosticsits raw SCADA frame, so since #143 a toggle run draws neither view. Nothing shows which of the test turbine's or the references' rows fed the estimate, which was the point of #153: a reference with bad data spoils an estimate as surely as a bad test turbine.A labelled run is unchanged: it keeps the validity scatters and does not get these figures.
Tests
TestReferenceOpsCurvesasserts the three figures per reference again, plus the reference-without-wind-speed case for all three.test_common_diagnostics_writes_expected_plotsandtest_optional_signals_skip_gracefullylistops_curves.png/ops_curves_kept_only.pngagain.poe all-fast: 2451 passed, 1 xfailed. The diagnostics module with slow tests: 31 passed.🤖 Generated with Claude Code