default to esmodule

[cometkim]

both for bsb and rewatch

[pkg-pr-new]

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@8128

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@8128

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@8128

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@8128

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@8128

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@8128

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@8128

commit: 9ef1dc2

[nojaf]

it is already in rewatch

Did you check? Or are you just assuming?

[cometkim]

Isn't it? I'm relying on my memory, but I'm aware that esmodule became the default somewhere.

[cometkim]

anyway, let's make it true.

[nojaf]

I would like you to check what rewatch actually does.

[nojaf]

Also, isn't changing defaults a breaking change?
If users did not specify anything in there rescript.json, won't the output be different?

[cometkim]

Now it is

[cometkim]

This was scheduled to be included in the v12 release, but was missed. It may be delayed until v13.

[zth]

If it goes into 12.1 and not a patch release, it should be fine I think.

[cknitt]

Suggested change

	- Output format is `esmoule` by default. https://github.com/rescript-lang/rescript/pull/8128
	- Output format is `esmodule` by default. https://github.com/rescript-lang/rescript/pull/8128

[cknitt]

If it goes into 12.1 and not a patch release, it should be fine I think.

Yes, and master is on 12.1 now, so that's fine.

[nojaf]

This was scheduled to be included in the v12 release, but was missed. It may be delayed until v13.

Do you have any links to where that was decided?

I'm on board with the change, but the timing is off-putting. It's bizarre that this never came up during all those rewatch changes. I do find a breaking change in a minor release kind of sacrilegious, though.

[cometkim]

I put that comment in #6709

I do find a breaking change in a minor release kind of sacrilegious, though.

And I agree with your thought.

[cometkim]

We don't need to rush. It's enough if this isn't forgotten and is included in the next major release.

[cknitt]

Also fine with me 🙂, then I'll assign it to the v13 milestone.

[cometkim]

shoud be rebased into #8130