Open
Conversation
coorasse
requested changes
Feb 16, 2026
Member
coorasse
left a comment
coorasse
left a comment
There was a problem hiding this comment.
From the last discussion, we should enable grouped coverage.
Contributor
Author
Why? I don't see how this relates to the app setup for eval coverage. |
Contributor
Author
|
The coverage groups would mainly be relevant in existing projects when we introduce eval. |
Member
|
I am a bit afraid of being too strict. But you are right! Let's see if that's fine also for others |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since a couple years time, simplecov supports eval coverage.
This allows us to also check for branch and line coverage within
erbfiles.Most importantly views
html.erb. I propose we check the eval coverage in new applications by default.Related PRs: