fix: Preserve event_actions from @rx.event decorator in mixin event handlers

[benedikt-bartscher]

No description provided.

[codspeed-hq]

Merging this PR will not alter performance

✅ 8 untouched benchmarks

---

_{Comparing benedikt-bartscher:fix-mixin-event-actions (a8eab46) with main (8c22cd7)¹}

Footnotes

1. No successful run was found on main (56f8f97) during the generation of this report, so 8c22cd7 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

[greptile-apps]

Greptile Overview

Greptile Summary

Fixed a bug where event_actions (such as prevent_default and stop_propagation) from the @rx.event decorator were lost when event handlers were inherited from mixin classes. The fix mirrors the existing pattern used for preserving the BACKGROUND_TASK_MARKER attribute.

• Added preservation of _rx_event_actions attribute in the _copy_fn method
• Added test case to verify event_actions are properly preserved through mixin inheritance
• Follows existing code patterns for attribute preservation during function copying

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The fix is well-targeted and follows the existing pattern for preserving function attributes (mirrors BACKGROUND_TASK_MARKER preservation). The change is minimal, includes a comprehensive test case, and addresses a specific bug without introducing side effects.
• No files require special attention

Important Files Changed

Filename	Overview
reflex/state.py	Preserves _rx_event_actions attribute when copying event handler functions from mixins
tests/units/test_state.py	Adds test verifying event_actions are preserved when event handlers are inherited from mixins

Sequence Diagram

sequenceDiagram
    participant Decorator as @rx.event decorator
    participant MixinClass as EventActionsMixin
    participant CopyFn as _copy_fn method
    participant ChildClass as UsesEventActionsMixin
    participant CreateHandler as _create_event_handler

    Note over Decorator,MixinClass: Mixin Definition
    Decorator->>MixinClass: Decorate handle_with_actions()
    Decorator->>MixinClass: Set _rx_event_actions attribute
    
    Note over ChildClass: Child Class Inherits Mixin
    ChildClass->>CopyFn: Copy event handler from mixin
    CopyFn->>CopyFn: Create new FunctionType
    CopyFn->>CopyFn: Copy annotations
    CopyFn->>CopyFn: Preserve BACKGROUND_TASK_MARKER
    CopyFn->>CopyFn: Preserve _rx_event_actions (NEW)
    CopyFn->>ChildClass: Return copied function
    
    Note over CreateHandler: Event Handler Creation
    ChildClass->>CreateHandler: Create event handler
    CreateHandler->>CreateHandler: Get _rx_event_actions from fn
    CreateHandler->>ChildClass: Return EventHandler with event_actions

Loading

[greptile-apps]

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[masenf]

awesome! thanks