implement nodeAddressMap for sentinel #3145
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I’m Jit, a friendly security platform designed to help developers build secure applications from day zero with an MVS (Minimal viable security) mindset. In case there are security findings, they will be communicated to you as a comment inside the PR. Hope you’ll enjoy using Jit. Questions? Comments? Want to learn more? Get in touch with us. |
Contributor
|
Thank you for the PR. I’ve added it to my review list. |
Author
|
@PavelPashov any way we could try and re-run the tests for 8.0.2 to see if this is a flake? |
nkaradzhov
requested changes
Jan 6, 2026
Collaborator
nkaradzhov
left a comment
nkaradzhov
left a comment
There was a problem hiding this comment.
@elimelt thanks for this, it looks good in general. I just left couple of nits
Address PR review comments: - Remove duplicate #getNodeAddress methods from RedisSentinelInternal and RedisSentinelFactory - Add getMappedNode utility function in utils.ts that takes host, port, and nodeAddressMap - Update all callsites to use the new utility function This eliminates code duplication and makes the address mapping logic reusable.
Author
|
@nkaradzhov fixed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for nodeAddressMap to sentinel client options, equivalent to cluster's nodeAddressMap feature.
I'd like to be able to use/test Sentinel from outside a k8s cluster, but returned addresses aren't resolvable to the client
Closes #3144
Checklist
npm testpass with this change (including linting)?