Skip to content

Conversation

@ZdravkoDonev-redis
Copy link
Collaborator

  1. I added a few very important notes in the SQL scripts
  2. I added the last step, without which nothing will work - actually making RDI to use the custom Debezium image.

@github-actions
Copy link
Contributor

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the Oracle XStream setup documentation for RDI by adding critical setup instructions and clarifications. The updates ensure users can properly configure RDI to use custom Debezium images for Oracle XStream connectivity, which was previously missing and would prevent the setup from working.

Key changes:

  • Added important SQL script comments warning users to check if ARCHIVELOG mode is already enabled before executing database shutdown commands
  • Clarified that database commands should be run as sysdba user instead of oracle user
  • Added the critical step 5 documenting how to configure RDI to use the custom Debezium image via the rdi-operator configmap
Comments suppressed due to low confidence (1)

content/integrate/redis-data-integration/data-pipelines/prepare-dbs/oracle.md:652

  • The subsection is labeled "5.1. For VM installation" which implies there should be other subsections (e.g., 5.2 for other installation types), but no additional subsections are provided. Consider either removing the "5.1" numbering and just using a descriptive heading like "For VM installation:", or adding subsections for other installation types if they exist.
    ```bash

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

@andy-stark-redis andy-stark-redis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ZdravkoDonev-redis I've implemented some fixes: the Copilot stuff, renumbering the sections, and replacing the ASCII art with Mermaid diagrams (AI finds these easier to parse). The text otherwise LGTM, but you might want to have a quick check that my changes are OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants